Ignore non permissible urls when hiding as we can't open them which causes issues. Fixes #793

2017-09-07 10:12:25 -07:00
parent 9b83068234
commit ae79f0a303
2 changed files with 15 additions and 2 deletions
@@ -63,8 +63,7 @@ const backgroundLogic = {
      url = undefined;
    }

-    // We can't open these we just have to throw them away
-    if (new URL(url).protocol === "about:") {
+    if (!this.isPermissibleURL(url)) {
      return;
    }

@@ -76,6 +75,17 @@ const backgroundLogic = {
    });
  },

+  isPermissibleURL(url) {
+    const protocol = new URL(url).protocol;
+    // We can't open these we just have to throw them away
+    if (protocol === "about:"
+        || protocol === "chrome:"
+        || protocol === "moz-extension:") {
+      return false;
+    }
+    return true;
+  },
+
  checkArgs(requiredArguments, options, methodName) {
    requiredArguments.forEach((argument) => {
      if (!(argument in options)) {