Commit Graph

464 Commits

Author SHA1 Message Date
Anton Dudakov 2f6596259b address feedback 02 2026-02-26 22:01:54 +04:00
Anton Dudakov eda79aaf05 address feedback 2025-12-20 19:40:42 +04:00
Anton Dudakov 37a2b67224 fixes merge conflicts 2025-12-20 19:40:42 +04:00
Anton Dudakov fb5eb2c0db extracted reopenInContainer function which made it possible to remove
async from the `init()`
2025-12-20 19:40:39 +04:00
Anton Dudakov b4d0115d22 adds an ability to reopen current tab in the specific container with a shortcut 2025-12-20 19:40:33 +04:00
Andrea Marchesini 02f9ea8ec9 Merge pull request #2835 from emilio/page-action-dark-mode
icons: Honor context-fill / context-fill-opacity, and dark mode as a fallback in page action icon
2025-12-12 15:49:06 +01:00
Emilio Cobos Álvarez 50e4b2742f icons: Honor context-fill / context-fill-opacity, and dark mode as a fallback in page action icon
The only reason this icon doesn't look terrible in dark mode is because
there's a hack in Firefox that we want to remove, see bug 2001318.
2025-12-10 23:00:42 +01:00
Andrea Marchesini 0539c12ba2 Final survey 2025-11-18 10:41:30 +01:00
Andrea Marchesini 91a92bd446 Data consent dialog not required + version bump 2025-10-29 15:04:41 +01:00
Andrea Marchesini 0cf1e14731 Fix a typo 2025-10-28 15:01:04 +01:00
Andrea Marchesini f377174bf2 Mark all the unknown achievements as done and remove the survey one during the installation 2025-10-28 14:56:52 +01:00
Lesley Norton 542161f8b4 Also bump version in manifest.json 2025-10-17 12:49:32 -05:00
Lesley Norton 56c5838d2d Revert "Merge pull request #2803 from mozilla/survey"
This reverts commit c34c1c1e04, reversing
changes made to adbf310a17.
2025-10-17 12:31:00 -05:00
Lesley Norton 35956f132a Revert "Temporarily hide engagement survey and bump version"
This reverts commit b4ad47bf04.
2025-10-17 12:30:08 -05:00
Lesley Norton b4ad47bf04 Temporarily hide engagement survey and bump version 2025-10-17 12:19:00 -05:00
Andrea Marchesini 2908419671 Fix a typo 2025-10-02 18:23:04 +02:00
Andrea Marchesini e296f438fa Update src/js/background/messageHandler.js
Co-authored-by: luke crouch <lcrouch@mozilla.com>
2025-10-02 18:19:55 +02:00
Andrea Marchesini 85ce6375e5 Update src/js/background/messageHandler.js
Co-authored-by: Maxx Crawford <maxx.crawford@gmail.com>
2025-10-02 18:19:35 +02:00
Andrea Marchesini dcc42e2a3a Update src/popup.html
Co-authored-by: Maxx Crawford <maxx.crawford@gmail.com>
2025-10-02 18:19:24 +02:00
Lesley Norton eeefaaba1e Fix CSS lint errors 2025-10-01 12:48:17 -05:00
Lesley Norton 00504ebbd9 Update survey panel 2025-10-01 19:26:06 +02:00
Andrea Marchesini 0eb13f214d Survey view 2025-10-01 19:25:53 +02:00
Andrea Marchesini adbf310a17 Merge pull request #2794 from loganrosen/usr-bin-env
Use `/usr/bin/env` instead of `/bin/env`
2025-10-01 09:42:16 +02:00
Logan Rosen bd7e33b11e Upgrade to eslint v9 2025-09-20 17:09:54 -04:00
Logan Rosen d3aa323a5a Use /usr/bin/env instead of /bin/env 2025-09-20 15:48:27 -04:00
Stephen Thompson 115d411218 Version upgrade 8.3.0
## IMPORTANT NOTE

Version 8.2.0 of this add-on configured Ctrl + Comma as the default keyboard shortcut for sorting the tab strip by container. This keyboard shortcut was removed from 8.3.0 in patch #2758. If you use Ctrl + Comma in order to quickly sort tabs by container, then you will need to explicitly reconfigure the keyboard shortcut. https://support.mozilla.org/en-US/kb/manage-extension-shortcuts-firefox

## Features
- #2753 Avoid sorting tabs in Firefox tab groups
- #2758 Removed suggested keyboard shortcut for tab sorting
- #2722 Removed Mozilla VPN logo banner

## Bugs
- #2572 Fixed add/remove site assignments logic bug
- #2754 Fixed "open/reopen in container" bug that would reopen outside of a Firefox tab group
- #2760 Removed console log spam related to context menu cleanup

## Developer
- #2671 Updated contributor documentation with tips and corrected links
- #2723 Updated GitHub Actions build image
2025-05-06 12:04:57 -04:00
Danny Colin aec2aa5fb0 Merge pull request #2722 from mozilla/basti/remove_vpn_banner
Remove the Mozilla-VPN Banner Ad
2025-04-30 22:00:04 -04:00
Sebastian Streich 69ee83bbf6 Remove the Mozilla-VPN Banner Ad 2025-04-30 21:57:36 -04:00
Danny Colin 9434147b48 Merge pull request #2758 from apostrophest/remove-sort-tabs-suggested-key
Remove suggested key for `sort_tabs`
2025-04-30 18:13:08 -04:00
Rob Wu 60a6666222 Avoid logspam: "Cannot find menu item with id ..."
The extension frequently tries to remove context menus that do not
exists, which results in errors like:

> Error: Cannot find menu item with id firefox-container-1

because starting from Firefox 136, the contextMenus.remove method
rejects if the menu item does not exist. To avoid logspam, catch it.

References:

- https://bugzilla.mozilla.org/show_bug.cgi?id=1688743
- https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/136#changes_for_add-on_developers
2025-04-30 00:51:11 +02:00
Stephen Thompson f1a24ed6fb Address code review comments for #2758
- Use `commands.reset` insead of `commands.update`
- Do not swallow errors
2025-04-29 16:36:19 -04:00
Danny Colin 0372abdc33 Merge pull request #2754 from apostrophest/issue-2747-reopen-in-container-tab-groups
Fix #2747: open/reopen container tabs in tab groups when appropriate
2025-04-28 11:04:18 -04:00
Stephen Thompson e96b275e02 Remove suggested key for sort_tabs
A number of users have accidentally pressed Ctrl + Comma and sorted their tabs by container. For some of those users, they did not know what had happened.

#2492 added Ctrl + Comma as a default shortcut key for sorting tabs by container. This change was released with addon v8.2.0 in Sept 2024.

It is useful to make the sort-tabs-by-container operation accessible by keyboard shortcut, but I think Ctrl + Comma is too close to the main Ctrl + Period shortcut for this addon. I think it's reasonable to make the default sort_tabs keyboard shortcut more complex, but in this patch, I'm recommending that we:

1. do not set a shortcut by default for any future users. Users can still configure a shortcut via Firefox's Manage Extension Shortcuts UI.
2. for existing users upgrading from 8.2.0 who configured their own, non-default keyboard shortcut for sort_tabs, keep their shortcut in place. These users demonstrated a strong interest in using the sort_tabs feature and I do not want to interfere.
3. for existing users upgrading from 8.2.0 who have the default keyboard shortcut configured, clear the shortcut. Users who did not use the sort_tabs keyboard shortcut will no longer be at risk of accidentally using it. Users who did use the default sort_tabs keyboard shortcut will be harmed, but those users can use the Manage Extension Shortcuts UI to manually configure Ctrl + Comma (or another key combination).

I am not aware of any simple ways to ensure that existing users using Ctrl + Comma can continue to do so without interruption. Ideally, I think #2492 should not have set a suggested key -- the other keyboard shortcuts are "non-destructive" and easy to understand. However, since that already happened, I think the best harm reduction approach at this point is to inconvenience existing users of Ctrl + Comma.
2025-04-25 13:08:44 -04:00
Stephen Thompson ab3e1ce4d8 Address code review from @Rob--W 2025-04-23 14:31:13 -04:00
Stephen Thompson 5194fcad0e Address code review from @Rob--W 2025-04-23 14:23:07 -04:00
Stephen Thompson b6a1bff9e8 Fix #2747: open/reopen container tabs in tab groups when appropriate
Firefox 137 introduced tab groups. Tab group web extension support is rolling out in Firefox 138 and later. Creating a new tab after the last tab in a tab group can inadvertently create the new tab outside of the tab group.

When a user opens a new tab that should be in a container, this patch will make sure that the new tab resides in the same tab group as the original tab.
2025-04-21 23:45:11 -04:00
Stephen Thompson 5ae2047b2c Fix #2746: sort only ungrouped tabs
Firefox 137 introduced tab groups. Tab group web extension support is rolling out in Firefox 138 and later. Tab movements, like the movements done when sorting tabs by container, can inadvertently add or remove tabs from tab groups.

In order to keep users' tab groups intact, this patch only sorts tabs outside of tab groups. Due to the lack of the tabGroups web extensions API as of Firefox 138, this patch cannot move tab groups, so all ungrouped tabs move to the end of the tab strip. That means after sorting, all tab groups will move to the beginning of the tab strip.
2025-04-21 23:44:13 -04:00
Cimbali 6fcb828e1d Fix error in function name 2024-09-26 13:10:25 +01:00
Cimbali aa9bb41305 Do not resolve promise twice 2024-09-26 13:10:25 +01:00
Rafee 8edcb1587d Version upgrade 2024-09-10 10:57:47 -04:00
Rafee Rahman 97891f61b0 Merge pull request #2659 from dannycolin/bz#1823729
Fix bz#1823729 - Listen only for status on tab updated
2024-08-29 09:22:53 -04:00
Danny Colin 51ead29d2b Fix bz#1823729 - Listen only for status on tab updated 2024-08-28 13:52:55 -04:00
luke crouch a53eb64c03 Merge pull request #2654 from mozilla/feat-#303
#303: Reset cookies in site manager
2024-08-28 11:26:57 -05:00
Rafee c644a60e46 feat #303: ask for browsing data permission dynamically 2024-08-27 17:06:07 -04:00
Rafee 2cd38299e2 feat #303: confirmation page for clearing container storage, added destructive colors 2024-08-27 15:34:06 -04:00
luke crouch 077c7e08c8 Merge pull request #2649 from mozilla/2263-always-open-in-container-bug
Remember choice for default containers in the "Always open in" confirm page
2024-08-27 13:47:53 -05:00
Rafee 6bde0a78d7 fix #2603: remember choice when choosing 'previous' (deny) container option 2024-08-23 12:57:50 -04:00
Rafee 3debe8a36f feat #303: change individual cookie removal to browsingData api 2024-08-20 15:04:25 -04:00
Rafee 606e08d2b7 feat #303: Container storage deletion and confirmation popup 2024-08-20 13:47:36 -04:00
Danny Colin f9f5daf8f4 Merge pull request #2616 from dannycolin/bug1958
Fix #1958 - Propagate container list reordering in Firefox menus
2024-08-14 10:31:54 -04:00